Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Handy script not playing after revisiting scene #5578

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

dumdum7
Copy link
Contributor

@dumdum7 dumdum7 commented Dec 27, 2024

Resolves #5577

The problem seems to be that the hook for player initialization is executed after the hook for script uploading. interactiveReady is first set to true by the script uploading hook (correct), but then gets reset to false by the player initialization hook (incorrect).

I think it's safe to delete the line I deleted since it should get set to false by the script uploading hook anyway, but I'm rather new to React, so please correct me if I'm wrong. There might even be a better way of solving this, like somehow ensuring the script uploading hook gets executed after the player initialization hook.

I tested the change locally. It fixed the problem and everything else seemed fine.

@WithoutPants WithoutPants added the bug Something isn't working label Jan 30, 2025
@WithoutPants WithoutPants added this to the Version 0.28.0 milestone Jan 30, 2025
@WithoutPants WithoutPants merged commit 9f7d00d into stashapp:develop Jan 30, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] Handy script not playing after revisiting scene
2 participants